-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README #8
Update README #8
Conversation
The README also has a section called "Disabling MySQL & MariaSQL" This addon automatically disables these in its |
I think we could leave some info in the readme about the config.*.yml because someone (like me) may use this add-on to connect to a second external sqlsrv db and not as main Drupal db. What do you think? |
Sounds reasonable. I think it's confusing that the addon describes how to disable the default database but disables it via a different file. Perhaps we need something like: "This addons disables the default database with via the And move the current instructions into a "Manually disabling the default DDEV database" for people who prefer to manage things themselves. Does this make sense or am I overthinking things? |
It makes sense. We could replace the paragraph like that: Manually enabling MySQL/MariaDBThis addons disables the default database by automatically adding If your project needs to use both MariaDB and MS SQL Server databases, you have to remove See .ddev/config.yaml Options for additional notes. |
That looks better to me. Not sure if you want to update this PR or open a new one. |
README.md
Outdated
@@ -20,7 +20,7 @@ ddev get robertoperuzzo/ddev-sqlsrv | |||
ddev restart | |||
``` | |||
|
|||
If in your project you already have a `.ddev/.env` file, you need to add the following lines to it: | |||
If your project you already has a `.ddev/.env` file, you need to add the following lines to it: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hint to replace it with => "If your project already has a custom .ddev/.env
file, you need to add the following lines to it:"
This PR makes some minor updates to the readme.
Fixes #7