Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify test setup with github-action-add-on-test, fixes #21 #23

Merged
merged 2 commits into from
Feb 23, 2024

Conversation

rfay
Copy link
Member

@rfay rfay commented Feb 19, 2024

The Issue

The github setup should be using github-action-add-on-test

How This PR Solves The Issue

Use it.

@rfay rfay changed the title simplify test setup with github-action-add-on-test simplify test setup with github-action-add-on-test, fixes #21 Feb 19, 2024
@rfay
Copy link
Member Author

rfay commented Feb 19, 2024

Please check this @julienloizelet, thanks.

@rfay
Copy link
Member Author

rfay commented Feb 19, 2024

This fails DDEV HEAD just because that's failing right now. Will be fixed in

@julienloizelet
Copy link

Hi @rfay ,

LGTM but we could also remove the DDEV_GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} at the top of the file:
the DDEV_GITHUB_TOKEN is in fact also handled by the add-ons-test action itself.

@rfay
Copy link
Member Author

rfay commented Feb 19, 2024

Removed, thanks!

@robertoperuzzo robertoperuzzo merged commit d63bd4e into ddev:main Feb 23, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants