-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix permissions on /run/php so php-fpm can run, fixes #20 #22
Conversation
6bb16ad
to
302f593
Compare
I think this will work, but requires a release, or the release build fails on HEAD. |
28562af
to
a3fdfd1
Compare
Sorry @rfay, when you write
to test it manually, could you give me instructions to do it? |
You bet, see https://ddev.readthedocs.io/en/latest/developers/building-contributing/#testing-latest-commits-on-head Thanks for maintaining this! |
Tested locally and it is fine. I'm going to merge it and then I re-enable the release test. I will open a new issue to update the |
This will need a release to get tests green, thanks! |
The Issue
Something about the Dockerfile for this has set /run/php permissions differently.
Moving this to pre.Dockerfile seems to solve the problem, but we still have to chmod the /run/php in the Dockerfile.
How This PR Solves The Issue
Set them back to 777
Manual Testing Instructions
Try to work with DDEV HEAD
Release/Deployment Notes