Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix permissions on /run/php so php-fpm can run, fixes #20 #22

Merged
merged 4 commits into from
Feb 25, 2024

Conversation

rfay
Copy link
Member

@rfay rfay commented Feb 19, 2024

The Issue

Something about the Dockerfile for this has set /run/php permissions differently.
Moving this to pre.Dockerfile seems to solve the problem, but we still have to chmod the /run/php in the Dockerfile.

How This PR Solves The Issue

Set them back to 777

Manual Testing Instructions

Try to work with DDEV HEAD

Release/Deployment Notes

  • Testing of the release has been remove temporarily, so needs to be re-enabled after this is in a release.

@rfay rfay marked this pull request as draft February 19, 2024 02:57
@rfay
Copy link
Member Author

rfay commented Feb 19, 2024

I think this will work, but requires a release, or the release build fails on HEAD.

@robertoperuzzo
Copy link
Collaborator

Sorry @rfay, when you write

Try to work with DDEV HEAD

to test it manually, could you give me instructions to do it?
I would test this PR locally, but I don't remember how to do it. ;(

@rfay
Copy link
Member Author

rfay commented Feb 23, 2024

@robertoperuzzo
Copy link
Collaborator

Tested locally and it is fine. I'm going to merge it and then I re-enable the release test.

I will open a new issue to update the pre.Dockerfile.sqlsrv to Debian 12; probably it will fix the permission on /run/php

@robertoperuzzo robertoperuzzo marked this pull request as ready for review February 25, 2024 13:53
@robertoperuzzo robertoperuzzo merged commit fca1032 into ddev:main Feb 25, 2024
4 checks passed
@rfay
Copy link
Member Author

rfay commented Feb 25, 2024

This will need a release to get tests green, thanks!

@rfay rfay deleted the 20240218_php_pid branch February 25, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants