-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sed on mac needs -e #25
Conversation
this should work on any system |
This is a classic problem of trying to do something on the host. On ddev-platformsh I broke down and made a docker image just for this kind of problem, see https://github.com/ddev/ddev-platformsh/blob/28b127817ed9bdfa2175c30f915b6a236e6c5a4c/install.yaml#L134 The Dockerfile is at https://github.com/ddev/ddev-utilities and the image at https://hub.docker.com/r/ddev/ddev-utilities I imagine it has a reliable sed in it that can be used predictably. Just a possibility |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uh, this was a mistake.
Did'nt want this in the pullrequest. Sorry!
The second commit was not really intented.
You can revert your bad commit and push... that's all you have to do. |
This reverts commit e66b6a8.
sed is bugging out on macOS. We use docker image and standardized sed
I've implemented the sed fix with the ddev-util docker image. Thanks for reporting this and for the initial implementation 💪 |
🎉 This PR is included in version 2.6.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
The Issue
See Issue #24
sed on macos needs "-e" before the script
How This PR Solves The Issue
changes
sed -i "s/REPLACE_ME/${DDEV_SITENAME}/g" redis/snapshots
to
sed -i -e "s/REPLACE_ME/${DDEV_SITENAME}/g" redis/snapshots
Manual Testing Instructions
on mac
cd into ddev project
ddev get ddev-redis-7