Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No default port is bound, so hard to use on gitpod or codespaces #3

Closed
RCheesley opened this issue Jul 25, 2023 · 3 comments
Closed

Comments

@RCheesley
Copy link

Hi folks!

When we tried to upgrade to 1.22.0 in this PR we came up against an issue whereby the PHPMyAdmin port was not getting correctly kicked off in Gitpod, so it was not accessible to users for testing.

It might well be a problem that other Gitpod / Codespace users come across, and can be worked around with the docker-compose.gitpod.yml using

services:
  phpmyadmin:
    ports:
    - "8036:80"

in case others come across this from search (thanks @rfay for the suggestion!) but it might be helpful to declare the ports explicitly in the plugin?

@rfay rfay changed the title Issue with ports on Gitpod with DDEV 1.22.0 No default port is bound, so hard to use on gitpod or codespaces Jul 25, 2023
@rfay
Copy link
Member

rfay commented Jul 25, 2023

I think this should be pretty easy to deal with. What we can do is

if the router is not enabled (Detect maybe with {{ .DdevGlobalConfig.omit_containers}} )

That should do it. PR is welcome.

@rfay
Copy link
Member

rfay commented Jul 26, 2023

Please test

Testing instructions are there. I think it should sort this out, seems to work OK for me on gitpod.

@rfay rfay closed this as completed in e9a3c79 Jul 27, 2023
@rfay
Copy link
Member

rfay commented Jul 27, 2023

This is released, please see how it goes for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants