Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for code generation types not matching what node-soap produces #54

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

nahidakbar
Copy link

No description provided.

@nahidakbar
Copy link
Author

@cheindl what do I need to do to merge this?

@cheindl
Copy link

cheindl commented Jan 18, 2023

@dderevjanik Would it be possible to merge this request and to make a new release?

Copy link

@svogl svogl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I tried this patch on a WSDL and it did not work out for me as the data type had a namespace prefix, as in:
<s:element minOccurs="1" maxOccurs="1" name="DeviceID" type="s:int" />
(s being xmlns:s="http://www.w3.org/2001/XMLSchema" )

as a quick fix I kicked the namespace prefix via
if (type.indexOf(':')>0) {
type = type.substr(type.indexOf(':')+1)
}
works for me, but looks kind of ugly. Better ideas anyone?

johngeorgewright added a commit to johngeorgewright/wsdl-tsclient that referenced this pull request Sep 20, 2023
@ammarnajjar
Copy link

@svogl looks like this PR addresses that issue => #66

@dderevjanik dderevjanik merged commit 018b812 into dderevjanik:master Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants