Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Symfony Validator #289

Closed
wants to merge 5 commits into from
Closed

Upgrade Symfony Validator #289

wants to merge 5 commits into from

Conversation

hugohenrique
Copy link
Contributor

@hugohenrique hugohenrique commented Mar 8, 2016 •
edited
Loading

  • Change composer.json to work with new version symfony validator
  • Update namespace ValidatorInterface
  • Update tests

@hugohenrique
Copy link
Contributor Author

ping @ddeboer

@rommsen
Copy link

rommsen commented May 27, 2016

@ddeboer any chance getting this merged?

@Baachi
Copy link
Collaborator

Baachi commented Jun 14, 2016

Can you squash your commits? Then i will merge it.

@hugohenrique
Copy link
Contributor Author

@Baachi How to do that? closing this PR opening a new?

@rommsen
Copy link

rommsen commented Jun 17, 2016

@Baachi cant you just use the merge and squash option?
https://help.github.com/articles/about-pull-request-merge-squashing/

@hugohenrique hugohenrique mentioned this pull request Jun 17, 2016
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hugohenrique @rommsen @Baachi