Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CsvReader's default delimiter should be a comma #79

Closed
gnat42 opened this issue Jun 11, 2014 · 1 comment
Closed

CsvReader's default delimiter should be a comma #79

gnat42 opened this issue Jun 11, 2014 · 1 comment
Milestone
1.0

Comments

@gnat42
Copy link
Contributor

gnat42 commented Jun 11, 2014

Hello,

I just spent awhile trying to figure out why my CSV file was not being read properly after creating a reader with new CsvReader($file);. It took awhile for me to figure out the CsvReader's constructor has a default delimiter of ';'. I find it bizarre that a CSV (aka Comma Separated Value) reader uses a semi colon instead of a comma. Is this not a bug?
@ddeboer
Copy link
Owner

ddeboer commented Jun 11, 2014

I agree! We should

  • add a note about the delimiter to the docs
  • change the default to ,, which makes more sense and is in accordance with PHP’s default, too.

@ddeboer ddeboer added this to the 1.0 milestone Jun 11, 2014
ddeboer added a commit that referenced this issue Jun 13, 2014
@ddeboer
Change default CSV delimiter to comma (fix #79)
9176a04
ddeboer added a commit that referenced this issue Jun 13, 2014
@ddeboer
Merge pull request #80 from ddeboer/csv-delimiter
9ccc60b 
Change default CSV delimiter to comma (fix #79)
@benr77 benr77 mentioned this issue Aug 20, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
2 participants
@ddeboer @gnat42