Replaces SplObjectStore with array in Steps

ddeboer · May 26, 2015 · f028439 · f028439
1 parent 981f20c
commit f028439
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 9 deletions.
diff --git a/src/Step/ConverterStep.php b/src/Step/ConverterStep.php
@@ -11,7 +11,7 @@
 class ConverterStep implements Step
 {
     /**
-     * @var \SplObjectStorage
+     * @var callable[]
      */
     private $converters;
 
@@ -20,8 +20,6 @@ class ConverterStep implements Step
      */
     public function __construct(array $converters = [])
     {
-        $this->converters = new \SplObjectStorage();
-
         foreach ($converters as $converter) {
             $this->add($converter);
         }
@@ -32,7 +30,7 @@ public function __construct(array $converters = [])
      */
     public function add(callable $converter)
     {
-        $this->converters->attach($converter);
+        $this->converters[] = $converter;
 
         return $this;
     }

diff --git a/src/Step/ValueConverterStep.php b/src/Step/ValueConverterStep.php
@@ -21,11 +21,7 @@ class ValueConverterStep implements Step
      */
     public function add($property, callable $converter)
     {
-        if (!isset($this->converters[$property])) {
-            $this->converters[$property] = new \SplObjectStorage();
-        }
-
-        $this->converters[$property]->attach($converter);
+        $this->converters[$property][] = $converter;
 
         return $this;
     }