Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add multi-document YAML support and update documentation #24

Merged
merged 1 commit into from
Dec 9, 2024
Merged

feat: add multi-document YAML support and update documentation #24

merged 1 commit into from
Dec 9, 2024

Conversation

Romain7495
Copy link
Contributor

@Romain7495 Romain7495 commented Dec 3, 2024 •
edited
Loading

fixes: #23

  • Add support for multiple YAML documents in a single file
  • Add support for invalid yaml
  • Add test cases for multi-document YAML handling
  • Add test cases for invalid yaml (duplicared keys)
  • Add test for quoted values (force)
  • Update README.md with forceQuotes option documentation

@Romain7495 Romain7495 force-pushed the master branch 4 times, most recently from f9c3a36 to 5e0efc6 Compare December 3, 2024 23:05
@Romain7495 Romain7495 changed the title feat: add multi-document YAML support and improve documentation feat: add multi-document YAML support and update documentation Dec 4, 2024
ddebin
ddebin reviewed Dec 4, 2024
View reviewed changes
yaml-sort.js Outdated Show resolved Hide resolved
ddebin
ddebin reviewed Dec 4, 2024
View reviewed changes
yaml-sort.js Outdated Show resolved Hide resolved
@ddebin
Copy link
Owner

ddebin commented Dec 4, 2024 •
edited
Loading

Thanks for the PR. I added a few comments. I didn't know this multi-doc syntax, but it seems document start (---) is optional (you check this point).

@Romain7495
Copy link
Contributor Author

@ddebin Thanks for your feedback. I don't add the starting document (---) when it's not present on original doc.

@Romain7495
Copy link
Contributor Author

hello @ddebin any news for this PR ?

@ddebin
Copy link
Owner

ddebin commented Dec 8, 2024

hello @ddebin any news for this PR ?

I will have a look tomorrow.

ddebin
ddebin reviewed Dec 9, 2024
View reviewed changes
yaml-sort.js Outdated Show resolved Hide resolved
@Romain7495
feat: add multi-document YAML support and improve documentation
9b49848 
                    - Add support for multiple YAML documents in a single file
                    - Add support for invalid yaml
                    - Add test cases for multi-document YAML handling
                    - Add test cases for invalid yaml (duplicared keys)
                    - Fix test expectations for quoted values
                    - Update README.md with forceQuotes option documentation

Signed-off-by: Romain LABAT <[email protected]>
@Romain7495
Copy link
Contributor Author

@ddebin should be good now

@ddebin ddebin merged commit 334b6c0 into ddebin:master Dec 9, 2024
6 checks passed
@ddebin
Copy link
Owner

ddebin commented Dec 9, 2024

Thanks for the PR! Merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddebin ddebin ddebin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for multiple YAML documents
2 participants
@Romain7495 @ddebin