Richo/hotplug events #42
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richo
commented
Feb 6, 2021
examples/hotplug_events.rs
Outdated
|
|
||
| fn main() -> Result<(), Box<dyn Error>> { | ||
| let mut ctx = libusb::Context::new()?; | ||
| ctx.register_callback(Default::default(), |device, event| { |
There was a problem hiding this comment.
@dcuddeback This is the user facing API, I'd love your thoughts on this part. I create a native &Device for the callback, and created an Event enum to mirror the libusb side but I'm open to other ideas here.
The libusb interface for filters doesn't really map onto rust super well so I made a builder style thing to let you create filters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I finally got something working as far as libusb callbacks go. This PR is a mess, I mostly wanted to run the API past you before I clean things up and unify (I created some aspirational modules while I was noodling and obviously it's not great to have a module with one enum in it).
I'll add some comments for the parts I'd like you to look at. Thanks!