-
Notifications
You must be signed in to change notification settings - Fork 1
Conversation
Use this link to sign into code climate with DCSIL https://codeclimate.com/activate/269226644aa55faa2f17be938b3452 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 5529 lines exceeds the maximum allowed for the inline comments feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 5526 lines exceeds the maximum allowed for the inline comments feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 5522 lines exceeds the maximum allowed for the inline comments feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 5523 lines exceeds the maximum allowed for the inline comments feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 5526 lines exceeds the maximum allowed for the inline comments feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 5526 lines exceeds the maximum allowed for the inline comments feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 5531 lines exceeds the maximum allowed for the inline comments feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 5529 lines exceeds the maximum allowed for the inline comments feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 5524 lines exceeds the maximum allowed for the inline comments feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 5524 lines exceeds the maximum allowed for the inline comments feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 5524 lines exceeds the maximum allowed for the inline comments feature.
@Windosaurus Since you got codeclimate working for frontend, I was wondering if you had any idea why I'm running into an issue here with circleci. I keep getting this error, no matter what I do. I tried using the commands as a single build (where I used after-build instead of format-coverage and upload-coverage) however I still got the same error:
I'm stuck and I've already read a bunch of similar issues such as this and this along with a bunch of other articles. Any ideas would be helpful. |
I found following this blog to be more useful than a lot of the code climate docs. |
@safaal28 circle ci can't find the actually coverage file, make sure you format it first and then you can run ls in the actual circleci command just to make sure that all the files are being sorted and formatted properly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 8360 lines exceeds the maximum allowed for the inline comments feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 8360 lines exceeds the maximum allowed for the inline comments feature.
Ready to merge imo |
@safaal28 looks great, could you just resolve the conflict and send in a new commit and I'll go ahead and approve the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 8710 lines exceeds the maximum allowed for the inline comments feature.
@Windosaurus resolved the conflict! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 10994 lines exceeds the maximum allowed for the inline comments feature.
Code Climate has analyzed commit 3a54595 and detected 5 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 52.5%. View more on Code Climate. |
Noice! |
Following code climate instructions from here. Signed up for code climate using the organization link from here.