Skip to content
This repository has been archived by the owner on Mar 5, 2024. It is now read-only.

Code Climate #32

Merged
merged 38 commits into from
Apr 1, 2022
Merged

Code Climate #32

merged 38 commits into from
Apr 1, 2022

Conversation

safaal28
Copy link
Contributor

Following code climate instructions from here. Signed up for code climate using the organization link from here.

@safaal28 safaal28 changed the title WIP: steps 1 and 2 for javascript WIP: Code Climate Mar 21, 2022
@safaal28
Copy link
Contributor Author

Use this link to sign into code climate with DCSIL https://codeclimate.com/activate/269226644aa55faa2f17be938b3452

@safaal28 safaal28 mentioned this pull request Mar 24, 2022
@safaal28 safaal28 linked an issue Mar 24, 2022 that may be closed by this pull request
@safaal28 safaal28 self-assigned this Mar 28, 2022
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 5529 lines exceeds the maximum allowed for the inline comments feature.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 5526 lines exceeds the maximum allowed for the inline comments feature.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 5522 lines exceeds the maximum allowed for the inline comments feature.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 5523 lines exceeds the maximum allowed for the inline comments feature.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 5526 lines exceeds the maximum allowed for the inline comments feature.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 5526 lines exceeds the maximum allowed for the inline comments feature.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 5531 lines exceeds the maximum allowed for the inline comments feature.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 5529 lines exceeds the maximum allowed for the inline comments feature.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 5524 lines exceeds the maximum allowed for the inline comments feature.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 5524 lines exceeds the maximum allowed for the inline comments feature.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 5524 lines exceeds the maximum allowed for the inline comments feature.

@safaal28
Copy link
Contributor Author

@Windosaurus Since you got codeclimate working for frontend, I was wondering if you had any idea why I'm running into an issue here with circleci.

image

image

I keep getting this error, no matter what I do.
image

I tried using the commands as a single build (where I used after-build instead of format-coverage and upload-coverage) however I still got the same error:

DEBU[0000] couldn't load committed at from ENV, trying git... 
Error: could not find coverage info for source files
Usage:
  cc-test-reporter format-coverage [coverage file] [flags]

I'm stuck and I've already read a bunch of similar issues such as this and this along with a bunch of other articles.

Any ideas would be helpful.

@safaal28
Copy link
Contributor Author

I found following this blog to be more useful than a lot of the code climate docs.

@Windosaurus
Copy link
Contributor

@safaal28 circle ci can't find the actually coverage file, make sure you format it first and then you can run ls in the actual circleci command just to make sure that all the files are being sorted and formatted properly.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 8360 lines exceeds the maximum allowed for the inline comments feature.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 8360 lines exceeds the maximum allowed for the inline comments feature.

@safaal28 safaal28 changed the title WIP: Code Climate Code Climate Apr 1, 2022
@safaal28
Copy link
Contributor Author

safaal28 commented Apr 1, 2022

Ready to merge imo

@Windosaurus
Copy link
Contributor

@safaal28 looks great, could you just resolve the conflict and send in a new commit and I'll go ahead and approve the PR.

@safaal28 safaal28 removed the request for review from stella-cai April 1, 2022 20:47
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 8710 lines exceeds the maximum allowed for the inline comments feature.

@safaal28
Copy link
Contributor Author

safaal28 commented Apr 1, 2022

@Windosaurus resolved the conflict!

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 10994 lines exceeds the maximum allowed for the inline comments feature.

@codeclimate
Copy link

codeclimate bot commented Apr 1, 2022

Code Climate has analyzed commit 3a54595 and detected 5 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 5

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 52.5%.

View more on Code Climate.

@Windosaurus
Copy link
Contributor

Noice!

@Windosaurus Windosaurus merged commit 2828663 into main Apr 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add repo to Code Climate
2 participants