Use inline cheap source maps for development mode #1089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
erikras/react-redux-universal-hot-example#616 (comment)
Before:
delta:dcos-ui ml (master)$ npm start ... content is served from /Users/ml/Mesosphere/dcos-ui/build Time: 68228ms chunk {0} index.js (main) 9.86 MB [rendered] Child html-webpack-plugin for "index.html": chunk {0} index.html 200 kB [rendered] webpack: bundle is now VALID. webpack: bundle is now INVALID. Time: 9482ms chunk {0} index.js, 0.17c12013250a06570382.hot-update.js (main) 9.86 MB [rendered] Child html-webpack-plugin for "index.html": chunk {0} index.html 200 kB webpack: bundle is now VALID. webpack: bundle is now INVALID. Time: 3639ms chunk {0} index.js, 0.6e5a4047e21c3640a600.hot-update.js (main) 9.86 MB [rendered] Child html-webpack-plugin for "index.html": chunk {0} index.html 200 kB webpack: bundle is now VALID. webpack: bundle is now INVALID. Time: 3597ms chunk {0} index.js, 0.ec9b2d9825ecdff0f341.hot-update.js (main) 9.86 MB [rendered] Child html-webpack-plugin for "index.html": chunk {0} index.html 200 kB webpack: bundle is now VALID. webpack: bundle is now INVALID. Time: 2902ms chunk {0} index.js, 0.bfddbe22805b35cff948.hot-update.js (main) 9.86 MB [rendered] Child html-webpack-plugin for "index.html": chunk {0} index.html 200 kB webpack: bundle is now VALID.=> Reloads between 3-4s
After:
delta:dcos-ui ml (master)$ npm start ... content is served from /Users/ml/Mesosphere/dcos-ui/build Time: 59161ms chunk {0} index.js (main) 9.86 MB [rendered] Child html-webpack-plugin for "index.html": chunk {0} index.html 200 kB [rendered] webpack: bundle is now VALID. webpack: bundle is now INVALID. Time: 5313ms chunk {0} index.js, 0.17c12013250a06570382.hot-update.js (main) 9.86 MB [rendered] Child html-webpack-plugin for "index.html": chunk {0} index.html 200 kB webpack: bundle is now VALID. webpack: bundle is now INVALID. Time: 2542ms chunk {0} index.js, 0.6e5a4047e21c3640a600.hot-update.js (main) 9.86 MB [rendered] Child html-webpack-plugin for "index.html": chunk {0} index.html 200 kB webpack: bundle is now VALID. webpack: bundle is now INVALID. Time: 2688ms chunk {0} index.js, 0.ec9b2d9825ecdff0f341.hot-update.js (main) 9.86 MB [rendered] Child html-webpack-plugin for "index.html": chunk {0} index.html 200 kB webpack: bundle is now VALID. webpack: bundle is now INVALID. Time: 2902ms chunk {0} index.js, 0.bfddbe22805b35cff948.hot-update.js (main) 9.86 MB [rendered] Child html-webpack-plugin for "index.html": chunk {0} index.html 200 kB webpack: bundle is now VALID.=> Reloads between 2.5-3s