Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it possible to specify architecture? #8

Open
javihernandez opened this issue Nov 9, 2020 · 3 comments
Open

Is it possible to specify architecture? #8

javihernandez opened this issue Nov 9, 2020 · 3 comments

Comments

@javihernandez
Copy link

First of all, thanks for providing such useful action 👍

This is not an issue but a question.
With nvm you can specify the architecture, i.e.:

nvm install 12.16.3 32
nvm use 12.16.3 32

Is this something you're up to support?

@dcodeIO
Copy link
Owner

dcodeIO commented Nov 9, 2020

Hmm, good question. Haven't had a need for this yet, but if it is useful to you then I'm happy to accept a PR :)

@ljharb
Copy link

ljharb commented Nov 9, 2020

That’s not a feature of nvm itself, only nvm-windows.

@javihernandez
Copy link
Author

javihernandez commented Nov 9, 2020

That’s not a feature of nvm itself, only nvm-windows.

So true, I've been using nvm on both gnu/linux and windows for years and I'm just realizing it's only available in nvm-windows, never needed this on gnu/linux. Sorry for any confusion.

In our case, we have some legacy code that uses some Windows APIs and by the time of writing it, we still had Windows 7 and Windows 8 around. Recently, we started moving into github actions as CI (before we had our CI spinning up custom vagrant boxes where node 32 was installed via chocolatey), and even though the code was supposed to be ready to run on 64 bit, it still requires some porting work here and there. That's the reason we're still building against node 32 bit on windows.

I totally understand if you don't like the idea of supporting this feature. In the other hand, we can mention in the README that specifying the architecture only works on nvm-windows. i.e.: adding an input field "node-arch" that only works when running on Windows.

@dcodeIO if you're still open to review/accept a PR, I can get to it when I get some free cycles. If you change your mind and prefer not to include it, I'd be happy too and the issue can be closed.

javihernandez added a commit to javihernandez/setup-node-nvm that referenced this issue Nov 10, 2020
javihernandez added a commit to javihernandez/setup-node-nvm that referenced this issue Nov 10, 2020
javihernandez added a commit to javihernandez/setup-node-nvm that referenced this issue Nov 10, 2020
javihernandez added a commit to javihernandez/setup-node-nvm that referenced this issue Nov 10, 2020
javihernandez added a commit to javihernandez/setup-node-nvm that referenced this issue Nov 10, 2020
javihernandez added a commit to javihernandez/setup-node-nvm that referenced this issue Nov 23, 2020
javihernandez added a commit to javihernandez/setup-node-nvm that referenced this issue Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants