Skip to content

Commit

Permalink
move headless build target to makefiles/lin
Browse files Browse the repository at this point in the history
  • Loading branch information
dckc committed Dec 30, 2019
1 parent ff41561 commit fab808c
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 13 deletions.
13 changes: 1 addition & 12 deletions .github/workflows/build-release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,21 +11,10 @@ jobs:
- uses: actions/checkout@v1
- name: build moddable headless tools
run: |
# ISSUE: move this to a makefile stanza?
export MODDABLE=$PWD
export XS_DIR=$MODDABLE/xs
cd $MODDABLE/build/makefiles/lin
# debug
# ISSUE: why are debug tools needed?
make -f $XS_DIR/makefiles/lin/xsc.mk
make -f $XS_DIR/makefiles/lin/xsid.mk
make -f $XS_DIR/makefiles/lin/xsl.mk
make -f tools.mk
# release
make GOAL=release -f $XS_DIR/makefiles/lin/xsc.mk
make GOAL=release -f $XS_DIR/makefiles/lin/xsid.mk
make GOAL=release -f $XS_DIR/makefiles/lin/xsl.mk
make GOAL=release -f tools.mk
make headless
- name: check that helloworld builds
run: |
export MODDABLE=$PWD
Expand Down
15 changes: 14 additions & 1 deletion build/makefiles/lin/makefile
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,20 @@ release:
make GOAL=release -f simulator.mk
make GOAL=release -f tools.mk
$(MODDABLE)/build/bin/lin/release/mcconfig -m -p x-lin $(MODDABLE)/tools/xsbug/manifest.json


# ISSUE: why do headless builds fail without debug tools?
headless:
make -f $(XS_DIR)/makefiles/lin/xsc.mk
make -f $(XS_DIR)/makefiles/lin/xsid.mk
make -f $(XS_DIR)/makefiles/lin/xsl.mk
make -f tools.mk
$(MODDABLE)/build/bin/lin/debug/mcconfig -d -m -p x-lin $(MODDABLE)/tools/xsbug/manifest.json
make GOAL=release -f $(XS_DIR)/makefiles/lin/xsc.mk
make GOAL=release -f $(XS_DIR)/makefiles/lin/xsid.mk
make GOAL=release -f $(XS_DIR)/makefiles/lin/xsl.mk
make GOAL=release -f tools.mk
$(MODDABLE)/build/bin/lin/release/mcconfig -m -p x-lin $(MODDABLE)/tools/xsbug/manifest.json

clean:
make clean -f $(XS_DIR)/makefiles/lin/xsc.mk
make clean -f $(XS_DIR)/makefiles/lin/xsid.mk
Expand Down

0 comments on commit fab808c

Please sign in to comment.