First stab at fixing MQTT topic paths for HA discovery in 2023.8+ #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HomeAssistant 2023.8 changed the naming requirements for MQTT entities - entity names can no longer contain the device name. This means multiple entities might have the same name if you have multiple instances of the same device type, and they will clobber each other with the existing discovery topic naming scheme. This change inserts the host into the discovery topic name to avoid the clobbering.
|
Can this be merged? Homeassistant discovery is currently broken without it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HomeAssistant 2023.8 changed the naming requirements for MQTT entities - entity names can no longer contain the device name. This means multiple entities might have the same name if you have multiple instances of the same device type, and they will clobber each other with the existing discovery topic naming scheme. This change inserts the host into the discovery topic name to avoid the clobbering.