Upgrade JS dependencies #374
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dcermak can this one be merged ? |
dcermak
reviewed
Feb 20, 2024
Comment on lines
+146
to
+170
| const restartLanguageServer = function (): Promise<void> { | ||
| return new Promise((resolve) => { | ||
| if (disposableClient) { | ||
| client.stop().then(() => { | ||
| disposableClient.dispose(); | ||
| startLSPServer(); | ||
| resolve(); | ||
| }); | ||
| } else { | ||
| startLSPServer(); | ||
| resolve(); | ||
| } | ||
| }); | ||
| } | ||
|
|
||
| context.subscriptions.push(client.start()); | ||
| var disposableRestart = commands.registerCommand('salt-lsp.restart', () => { | ||
| restartLanguageServer().then(() => { | ||
| window.showInformationMessage('Salt-lsp server restarted.'); | ||
| }); | ||
| }); | ||
| context.subscriptions.push(disposableRestart); | ||
| await startLSPServer() | ||
| } | ||
|
|
||
| export function deactivate(): Thenable<void> { | ||
| return client ? client.stop() : Promise.resolve(); | ||
| } | ||
| export function deactivate(): Thenable<void> { return client ? client.stop() : Promise.resolve(); } |
There was a problem hiding this comment.
Can you please undo all the formatting changes in this file except for the actual change (which appears to me as this marked part)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bunch of depedencies pointed out by dependabot