Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corrected JSON storage (string -> serde value), added ON CONFLICT target column #4

Merged
merged 1 commit into from
Sep 20, 2022
Merged

Corrected JSON storage (string -> serde value), added ON CONFLICT target column #4

merged 1 commit into from
Sep 20, 2022

Conversation

kaibyao
Copy link
Contributor

@kaibyao kaibyao commented Sep 19, 2022

I had some issues with being able to store session information into a Postgres DB.

  1. I got a type error when inserting the session because it was expecting a JSON blob but got text instead, and
  2. I got a constraint error when inserting the session because ON CONFLICT contraints needed to be defined.

I've updated the code so that this conversion + conflict constraints work correctly.

@dcchut dcchut mentioned this pull request Sep 20, 2022
Merged
@dcchut
Copy link
Owner

dcchut commented Sep 20, 2022

Thanks - this looks good! I'm going to close and reopen which should (🤞) trigger the pull request action.

@dcchut dcchut closed this Sep 20, 2022
@dcchut dcchut reopened this Sep 20, 2022
@dcchut
Copy link
Owner

dcchut commented Sep 20, 2022 •
edited
Loading

Awesome, build is green, thanks again 👍. This fix has been released in 0.1.2.

@dcchut dcchut merged commit 32b173e into dcchut:main Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kaibyao @dcchut @kai-tock