Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Never select tabstop with regex transforms #67

Merged
merged 1 commit into from
May 29, 2022

Conversation

bjin
Copy link
Contributor

@bjin bjin commented May 29, 2022

Fixes #66

@bjin
Copy link
Contributor Author

bjin commented May 29, 2022

I did some testing and found out that in combine with a placeholder like ${1:something}, this patch just mess up cursor position. Some indexing code might silently depends on a liner scan (from left to right) for same tabstop, I guess. I don't know much about the codebase. Some small digging just make things even more confusing.

Closing for now, as I couldn't come up with a proper fix.

@bjin bjin closed this May 29, 2022
@bjin
Copy link
Contributor Author

bjin commented May 29, 2022

Replace $1 with ${1:&n} to test how the code handles placeholders.

@dcampos
Copy link
Owner

dcampos commented May 29, 2022

I'll reopen and merge this, as I think I've found a fix for the placeholder bug.

@dcampos dcampos reopened this May 29, 2022
@dcampos dcampos merged commit 4d92955 into dcampos:master May 29, 2022
dcampos added a commit that referenced this pull request May 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regex transformed tabstop are expanded if it occurs before its source tabstop
2 participants