Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup the Gruntfile #849

Merged
merged 4 commits into from
Apr 22, 2015
Merged

Cleanup the Gruntfile #849

merged 4 commits into from
Apr 22, 2015

Conversation

mtraynham
Copy link
Contributor

Hey Gordon,

This is basically round two of #844. Some things that have been changed here:

  • Upgrade the npm dependencies to the latest-minor versions. Seems I didn't catch the minor numbers previously.
  • Add load-grunt-tasks and time-grunt dependencies. These are small grunt utilities, one of which removes redundancy in the Gruntfile, the other logging the time per task.
  • Remove the grunt-sed task. grunt-contrib-concat has a process flag that allows us to use Grunt templates in the source files (e.g <%= conf.banner %>)
  • Take advantage of the banner property on concat and uglify tasks. No need to put it in the source code, so removed from src/banner.js.
  • In the Gruntfile, use config templates where necessary. Just convenience if you decide to move files.
  • Fix the sourceMap property of the uglify task. Should be a boolean.
  • Removes the difflib.js file from the stock-regression suite. This can be pulled from npm.

In the future, I'd prefer moving away from putting inline script tasks/multiTasks in the Gruntfile. There's minimal documentation around what they do, and it looks a bit convoluted.

@gordonwoodhull gordonwoodhull merged commit a719303 into dc-js:master Apr 22, 2015
@mtraynham mtraynham deleted the grunt_cleanup branch May 16, 2015 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants