Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Gordon,
This is basically round two of #844. Some things that have been changed here:
load-grunt-tasks
andtime-grunt
dependencies. These are small grunt utilities, one of which removes redundancy in the Gruntfile, the other logging the time per task.grunt-sed
task.grunt-contrib-concat
has aprocess
flag that allows us to use Grunt templates in the source files (e.g<%= conf.banner %>
)banner
property onconcat
anduglify
tasks. No need to put it in the source code, so removed fromsrc/banner.js
.sourceMap
property of theuglify
task. Should be a boolean.difflib.js
file from the stock-regression suite. This can be pulled fromnpm
.In the future, I'd prefer moving away from putting inline script tasks/multiTasks in the Gruntfile. There's minimal documentation around what they do, and it looks a bit convoluted.