Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update legend text y calculation #1855 & #1852 #1856

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Spacarar
Copy link

After reading about these two issues, I was investigating the cause of this and found that on chrome the clientHeight was returning a much smaller value than getBoundingClientRect().height which was returning more consistent results across environments for me.

Please let me know if there are any issues with the code here so I can adjust accordingly.

@kum-deepak
Copy link
Collaborator

Many thanks! I have checked the code and it seems all fine. The CI testes Edge, Chrome, Firefox, and Safari, so, I guess we are good. This change request will get merged and released as part of the next release.

@ufundo
Copy link

ufundo commented Aug 19, 2024

Any chance of this fix being released for existing stable version?

@powelleric
Copy link

I would also love to have this fix. Thanks a bunch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants