Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dc.js #1124

Closed
wants to merge 3 commits into from
Closed

Update dc.js #1124

wants to merge 3 commits into from

Conversation

pfafman
Copy link
Contributor

@pfafman pfafman commented Apr 6, 2016

Cross filter community fork: crossfilter2 is needed int the require statement

pfafman added 3 commits April 6, 2016 16:03
Cross filter community fork: crossfilter2 is needed int the require statement
@gordonwoodhull
Copy link
Contributor

Thanks @pfafman, I'm pulling commit e380307 into the 2.0 beta 28 release. (There are some other commits on this branch which I don't think are relevant.)

@pfafman
Copy link
Contributor Author

pfafman commented Apr 30, 2016

Gordon,

This is still an issue in the last deployed NPM. the dc.js file still is requiring crossfilter and not crossfilter2

Tim

On Apr 29, 2016, at 1:56 PM, Gordon Woodhull [email protected] wrote:

Thanks @pfafman https://github.com/pfafman, I'm pulling commit e380307 e380307 into the 2.0 beta 28 release. (There are some other commits on this branch which I don't think are relevant.)


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub #1124 (comment)

@gordonwoodhull
Copy link
Contributor

Drat! I hadn't noticed that you made the change to the output file rather than the input; it belongs in src/footer.js.

I'll do another release this morning.

And check the rest of the PRs I merged! I usually catch that!

@pfafman
Copy link
Contributor Author

pfafman commented Apr 30, 2016

Sorry about that. It was a quick fix so I could get it to work.

On Apr 30, 2016, at 7:04 AM, Gordon Woodhull [email protected] wrote:

Drat! I hadn't noticed that you made the change to the output file rather than the input; it belongs in src/footer.js.

I'll do another release this morning.

And check the rest of the PRs I merged! I usually catch that!


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub #1124 (comment)

@gordonwoodhull
Copy link
Contributor

Fixed for real in 2.0 beta 29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants