-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to dbus-next #15
Conversation
I do believe this works, but dbus-next is not released yet so you'll have to wait for that to merge. No breaking changes in the api were intended. I think it works, but it should be tested a bit more. I've talked to @sidorares and he said he is interested in merging the service interface of dbus-next. So consider this a reference implementation. |
Migration to dbus-next (a fork of dbus-native) is a rewrite, but fixes some outstanding bugs in the project related to variant types. The project is now transpiled to use the experimental decorator feature that will be available in the language at some later time. gulpfile.js contains build instructions. Build with `npm run build`. The dist/ folder contains what will be published on npm. Interfaces are implemented as classes with decorators specifying the properties of the member that is exported on the bus. Update examples and add a new tracklist example. Other bugfixes may have been a side effect of the rewrite. fixes dbusjs#1 fixes dbusjs#6 fixes dbusjs#13
Any news about this? |
@emersion sorry still didn't have any free time, maybe over holiday period |
No worries, and thanks for your hard work on dbus-native! |
Sorry for the rewrites. Can't wait to finally close my stupid playerctl bug. |
This would be absolutely awesome to have |
The last problem to solve is to get my required node engine version down to about 6.3 and then I can go about my glorious mission to fix javascript media players. |
Hey @emersion this is ready for review. Run Run tests with Build docs to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are still some TODOs, but I think it's better to merge this as-is. This LGTM.
Thanks for your hard work, that's quite impressive :)
Migration to dbus-next (a fork of dbus-native) is a rewrite, but fixes
some outstanding bugs in the project related to variant types.
The project is now transpiled to use the experimental decorator feature
that will be available in the language at some later time. gulpfile.js
contains build instructions. Build with
npm run build
. The dist/folder contains what will be published on npm.
Interfaces are implemented as classes with decorators specifying the
properties of the member that is exported on the bus.
Update examples and add a new tracklist example.
Other bugfixes may have been a side effect of the rewrite.
fixes #1
fixes #6
fixes #13