✨ zv: support kebab-case in rename_all #899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeenix
reviewed
Jul 13, 2024
zeenix
reviewed
Jul 13, 2024
zeenix
reviewed
Jul 13, 2024
Also add some tests for case conversion to ensure renamings are consistent Signed-off-by: Pascal Bach <[email protected]>
bachp
force-pushed
the
zvariant_derive-kebab-case
branch
from
8ed6e4b to
c5e2d63
Compare
zeenix
approved these changes
Jul 16, 2024
There was a problem hiding this comment.
Cool, thanks! It's so much easier to follow now. :) Although, I think we should change the API to only expose snake_case and kebab_case methods in the public API that are thin wrappers around snake_or_kebab_case, which isn't then exposed anymore. Same thing for pascal_or_camel_case. However, this can be done in an separate PR and not necessarily by you. :)
Also for future reference, I'd have split this commit into 3: the new zvariant_utils API, use of it in zbus_macros and finally the new tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add some tests for case conversion
to ensure renamings are consistent