Prepare for a release & add --print-address cli option
#26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Zeeshan Ali Khan <[email protected]> Signed-off-by: Marc-André Lureau <[email protected]>
zeenix
force-pushed
the
prepare-release
branch
2 times, most recently
from
48b2e4c to
4017988
Compare
Co-authored-by: Zeeshan Ali Khan <[email protected]> Signed-off-by: Marc-André Lureau <[email protected]>
This will create a release on Github from annotated tags.
Otherwise, the build breaks against latest nightly: ``` error[E0635]: unknown feature `proc_macro_span_shrink` --> /home/zeenix/.cargo/registry/src/index.crates.io-6f17d22bba15001f/proc-macro2-1.0.47/src/lib.rs:92:30 | 92 | feature(proc_macro_span, proc_macro_span_shrink) | ^^^^^^^^^^^^^^^^^^^^^^ ```
We might switch back to git after the release.
This also means we don't use two different versions of nix, as zbus also uses 0.26.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@elmarco I took 2 of your patches from #23 for this.
Zeeshan Ali Khan on behalf of MBition GmbH.
Provider Information.