Release runtime lock on Sdl.delay.

This could deadlock the audio thread (#13) and broke the test suite.
dbuenzli · Sep 26, 2016 · 7bd26fb · 7bd26fb
1 parent cfffca2
commit 7bd26fb
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/CHANGES.md b/CHANGES.md
@@ -1,5 +1,5 @@
 
-
+- Release runtime lock on `Sdl.delay`.
 - Reinstate support for audio callback support, `ocaml-ctypes`
   is getting smarter (#13).
 - Really fix signature of `Sdl.blit_surface`, thanks to

diff --git a/src/tsdl.ml b/src/tsdl.ml
@@ -4664,7 +4664,7 @@ let unlock_audio_device =
 (* Timer *)
 
 let delay =
-  foreign "SDL_Delay" (int32_t @-> returning void)
+  foreign ~release_runtime_lock:true "SDL_Delay" (int32_t @-> returning void)
 
 let get_ticks =
   foreign "SDL_GetTicks" (void @-> returning int32_t)

diff --git a/test/test.ml b/test/test.ml
@@ -1248,13 +1248,13 @@ let test_audio_drivers () =
         end;
       done
   end;
-  log " Quit audio";
+(*  log " Quit audio";
   Sdl.audio_quit ();
   log " Init audio with: %a" (Fmts.pp_opt Fmts.pp_str) driver;
   begin match Sdl.audio_init driver with
   | Error (`Msg e) -> log_err " Could not init audio: %s" e
   | Ok () -> ()
-  end;
+  end; *)
   ()
 
 let test_audio_devices () =