Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Python 3.12 #1237

Merged
merged 2 commits into from
Jun 3, 2024
Merged

Add Support for Python 3.12 #1237

merged 2 commits into from
Jun 3, 2024

Conversation

plypaul
Copy link
Contributor

@plypaul plypaul commented May 31, 2024

Resolves #1065

Description

This adds support for Python 3.12. Once this is merged, the plan is to:

  • Increment the version of MF and publish it.
  • Update dbt-metricflow to use that new version since CI depends on that package.
  • Update CI to add tests for Python 3.12.

Copy link
Contributor

@tlento tlento left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huzzah!

Note - we're still in this awkward place where I personally have to generate the attribution. Let me know if you want me to deal with the MetricFlow release. I can also just generate that update and add it to your release PR.

Base automatically changed from p--py312--05 to main June 3, 2024 21:24
@plypaul
Copy link
Contributor Author

plypaul commented Jun 3, 2024

Sure, that would be helpful. Let me verify things with a dev release first.

@plypaul plypaul merged commit 959ea06 into main Jun 3, 2024
15 checks passed
@plypaul plypaul deleted the p--py312--06 branch June 3, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SL-1831] [Feature] Add Python 3.12 Support
2 participants