Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hub.json for DataLakehouse.io #282

Closed
wants to merge 3 commits into from

Conversation

guilhermealc
Copy link
Contributor

@guilhermealc guilhermealc commented Sep 25, 2023

changing org name, to match current DataLakehouse branding.

Description

Just changing the org name

Link to your package's repository:

Checklist

This checklist is a cut down version of the best practices that we have identified as the package hub has grown. Although meeting these checklist items is not a prerequisite to being added to the Hub, we have found that packages which don't conform provide a worse user experience.

First run experience

  • [x ] The package includes a README which explains how to get started with the package and customise its behaviour
  • [ x] The README indicates which data warehouses/platforms are expected to work with this package

Customisability

  • [ x] The package uses ref or source, instead of hard-coding table references.

Packages for data transformation (delete if not relevant):

  • [ x] provide a mechanism (such as variables) to customise the location of source tables.
  • [ x] do not assume database/schema names in sources.

Dependencies

Dependencies on dbt Core

  • [x ] The package has set a supported require-dbt-version range in dbt_project.yml. Example: A package which depends on functionality added in dbt Core 1.2 should set its require-dbt-version property to [">=1.2.0", "<2.0.0"].

Dependencies on other packages defined in packages.yml:

  • [ x] Dependencies are imported from the dbt Package Hub when available, as opposed to a git installation.
  • [ x] Dependencies contain the widest possible range of supported versions, to minimise issues in dependency resolution.
  • [ x] In particular, dependencies are not pinned to a patch version unless there is a known incompatibility.

Interoperability

  • [x ] The package does not override dbt Core behaviour in such a way as to impact other dbt resources (models, tests, etc) not provided by the package.
  • [x ] The package uses the cross-database macros built into dbt Core where available, such as {{ dbt.except() }} and {{ dbt.type_string() }}.
  • [ x] The package disambiguates its resource names to avoid clashes with nodes that are likely to already exist in a project. For example, packages should not provide a model simply called users.

Versioning

  • [ x] (Required): The package's git tags validates against the regex defined in version.py
  • [ x] The package's version follows the guidance of Semantic Versioning 2.0.0. (Note in particular the recommendation for production-ready packages to be version 1.0.0 or above)

changing org name, to match current DataLakehouse branding.
@dbeatty10
Copy link
Contributor

@joellabes we have instructions here for adding/renaming packages. But we don't yet have instructions documented how to rename an org within hubcap / hub.getdbt.com.

So before merging this PR, we'll want to:

  1. Figure out what those instructions are
  2. Add them here
  3. Follow them for this PR

@dbeatty10
Copy link
Contributor

@guilhermealc to make sure we tie off all loose ends, could you open an associated PR within https://github.com/dbt-labs/hub.getdbt.com that follows these instructions?

You've already done Step 1 (this PR). You'd just need to do Steps 2 and 3.

Could you respond back to this thread when that is complete?

@guilhermealc
Copy link
Contributor Author

@dbeatty10 , these instructions looks related to changing the package name.
In our case we just want to change the organization name.
But our organization in GitHub is still named as Datalakehouse.... would that still be possible without changing our org name in github?

@dbeatty10
Copy link
Contributor

But our organization in GitHub is still named as Datalakehouse.... would that still be possible without changing our org name in github?

We utilize the organization in GitHub to list out all the packages listed at https://hub.getdbt.com/, so you'd need to change your GitHub org name if you want it to display differently within the dbt Package Hub.

With that information, do you want to proceed with this pull request, or would it be more appropriate to close it?

@guilhermealc
Copy link
Contributor Author

Gotcha @dbeatty10 , in this case I'll close the PR and open a new one when/if we have our org name updated.
Thanks!

@guilhermealc guilhermealc deleted the patch-4 branch September 28, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants