Contributing instructions #1723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbeatty10
force-pushed
the
dbeatty/contributing
branch
from
2e69277
to
c2c2a7a
Compare
github-actions
bot
force-pushed
the
dbeatty/contributing
branch
from
c2c2a7a
to
a3a6651
Compare
joellabes
requested changes
Jul 28, 2022
|
|
||
| You can set the `DBT_PACKAGE_HUB_URL` environment variable to specify where `dbt deps` should look to resolve dependencies [listed in `packages.yml`](https://docs.getdbt.com/docs/building-a-dbt-project/package-management#how-do-i-add-a-package-to-my-project): | ||
| ```shell | ||
| export DBT_PACKAGE_HUB_URL=http://localhost:4567/ |
There was a problem hiding this comment.
Perhaps instructions on how to delete this afterwards as well? Or at least a reminder to delete it afterwards
There was a problem hiding this comment.
Very good point! Committed an update to incorporate this feedback.
CONTRIBUTING.md
Outdated
|
|
||
| ### Installing Ruby for Mac | ||
|
|
||
| [https://antran.app/2021/m1_mac_part2/](https://antran.app/2021/m1_mac_part2/) |
There was a problem hiding this comment.
What is this link for? Do I only need to read it if I have an M1 Mac? Does it replace the instructions below if I'm on an M1? Is it where the below instructions came from?
There was a problem hiding this comment.
Committed an update to incorporate this feedback.
Co-authored-by: Joel Labes <[email protected]>
github-actions
bot
force-pushed
the
dbeatty/contributing
branch
from
d49fe05
to
858d100
Compare
joellabes
approved these changes
Aug 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1721, unlocks #1341
Overview
This is an initial set of instructions for doing development on this repository. It also includes a brief explanation how it relates to Hubcap and
dbt deps(from dbt Core).