Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing sqlfluff link #6560

Open
wants to merge 4 commits into
base: current
Choose a base branch
from
Open

Fixing sqlfluff link #6560

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ff2e202
Fixing sqlfluff link
matthewshaver Nov 27, 2024
3439a44
Update website/docs/best-practices/how-we-style/2-how-we-style-our-sq…
matthewshaver Nov 27, 2024
05a160d
Merge branch 'current' into linting
mirnawong1 Nov 28, 2024
16875a5
Merge branch 'current' into linting
mirnawong1 Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions website/docs/best-practices/how-we-style/2-how-we-style-our-sql.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ id: 2-how-we-style-our-sql
- ☁️ Use [SQLFluff](https://sqlfluff.com/) to maintain these style rules automatically.
- Customize `.sqlfluff` configuration files to your needs.
- Refer to our [SQLFluff config file](https://github.com/dbt-labs/jaffle-shop-template/blob/main/.sqlfluff) for the rules we use in our own projects.

- Exclude files and directories by using a standard `.sqlfluffignore` file. Learn more about the syntax in the [.sqlfluffignore syntax docs](https://docs.sqlfluff.com/en/stable/configuration.html#id2).
- Exclude files and directories by using a standard `.sqlfluffignore` file. Learn more about the syntax in the [.sqlfluffignore syntax docs](https://docs.sqlfluff.com/en/stable/configuration/index.html).
- Excluding often unnecessary folders and files (such as target/, dbt_packages/, and macros/) can decrease lint run times.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding the backticks and might be good to clarify if taylor meant job run times too?

Suggested change
- Excluding often unnecessary folders and files (such as target/, dbt_packages/, and macros/) can decrease lint run times.
- Excluding unnecessary folders and files (such as `target/`, `dbt_packages/`, and `macros/`) can speed up linting, improve run times, and help you avoid irrelevant logs.

- 👻 Use Jinja comments (`{# #}`) for comments that should not be included in the compiled SQL.
- ⏭️ Use trailing commas.
- 4️⃣ Indents should be four spaces.
Expand Down
Loading