Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update python-models.md to reflect changed default behaviour #6540

Merged
merged 4 commits into from
Nov 26, 2024

Conversation

joellabes
Copy link
Contributor

@joellabes joellabes commented Nov 26, 2024

What are you changing in this pull request and why?

The Python docs mentioned that we intended to change to anonymous sprocs in 1.4:

We plan to switch this on for all dbt + Snowpark Python models starting with the release of dbt Core version 1.4.

I have verified that the default is now different:
https://github.com/dbt-labs/dbt-snowflake/blob/8e027d8fcfbf3958cbc97dfe38fba153d1077a6d/dbt/adapters/snowflake/impl.py#L401

So am updating the docs accordingly. Since it goes back to 1.4, I haven't bothered with version blocks.


🚀 Deployment available! Here are the direct links to the updated files:

@joellabes joellabes requested a review from a team as a code owner November 26, 2024 05:01
Copy link

vercel bot commented Nov 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Nov 26, 2024 10:04am

@github-actions github-actions bot added content Improvements or additions to content size: small This change will take 1 to 2 days to address labels Nov 26, 2024
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm @joellabes !

@mirnawong1 mirnawong1 merged commit 32cada6 into current Nov 26, 2024
9 checks passed
@mirnawong1 mirnawong1 deleted the joellabes-patch-4 branch November 26, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content size: small This change will take 1 to 2 days to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants