Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update group config for analyses #4416

Closed
1 task done
dbeatty10 opened this issue Nov 8, 2023 · 3 comments · Fixed by #5846
Closed
1 task done

Update group config for analyses #4416

dbeatty10 opened this issue Nov 8, 2023 · 3 comments · Fixed by #5846
Assignees
@dbeatty10 @mirnawong1
Labels
content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear priority: high Technical inaccuracy, missing/incorrect information, or broken links. Negatively affects workflows size: x-small This change will take under 3 hours to fix.

Comments

@dbeatty10
Copy link
Contributor

Contributions

  • I have read the contribution docs, and understand what's expected of me.

Link to the page on docs.getdbt.com requiring updates

https://docs.getdbt.com/reference/resource-configs/group

What part(s) of the page would you like to see updated?

Do analyses really have a group config?! (I wouldn't guess so because analyses are not ref'able.)

Depending on the answer, either:

  • Remove example for analyses and replace with a message saying it isn't a valid config, or
  • Add a block for analyses to indicate the first version that the group was possible

Additional information

No response
@dbeatty10 dbeatty10 added content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear labels Nov 8, 2023
@dbeatty10 dbeatty10 mentioned this issue Nov 8, 2023
Merged
3 tasks
matthewshaver added a commit that referenced this issue Nov 8, 2023
@matthewshaver
group config for semantic models (#4220)
3f5133c 
related to: #3997
related to: #4281

## What are you changing in this pull request and why?
- Fix version blocks for other resource types
- Match the style for other resource types for
`models/semantic_models.yml`
- Fix code example in `dbt_project.yml` to refer to `semantic-models`
(since `semantic_models` won't work)
- Simplify the definition by removing an explicit listing of applicable
resource types
- rather than adding the missing ones (like seeds and semantic models)

## Other
- Opened an issue to standardize the order of code examples for
`dbt_project.yml` vs. `properties.yml`:
[#4417](#4417)
- Opened an issue to figure out: do analyses _really_ have a `group`
config?1
[#4416](#4416)
- Opened an issue to standardize on `<group_name>` instead of `finance`
in generic syntax examples
[#4418](#4418)

## 🎩

### Previews
-
[1.6](https://docs-getdbt-com-git-dbeatty-semantic-models-gro-95bd63-dbt-labs.vercel.app/reference/resource-configs/group?version=1.6)
-
[1.7](https://docs-getdbt-com-git-dbeatty-semantic-models-gro-95bd63-dbt-labs.vercel.app/reference/resource-configs/group?version=1.7)

### v1.7

<img width="500" alt="image"
src="https://github.com/dbt-labs/docs.getdbt.com/assets/44704949/73ad131a-2ec2-4e90-b04a-d9ccd41cb18f">

## Checklist
- [x] I have tested that the code examples work
- [x] I have tested that the changes look correct in the Vercel preview
- [x] Review the [Content style
guide](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/content-style-guide.md)
and [About
versioning](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#adding-a-new-version)
so my content adheres to these guidelines.
@graciegoheen graciegoheen added priority: high Technical inaccuracy, missing/incorrect information, or broken links. Negatively affects workflows size: x-small This change will take under 3 hours to fix. labels Jan 2, 2024
@mirnawong1 mirnawong1 self-assigned this Feb 1, 2024
@mirnawong1
Copy link
Contributor

have doubled check this here

@mirnawong1
Copy link
Contributor

asked again: https://dbt-labs.slack.com/archives/C017GDLAF7D/p1719827718815479

@dbeatty10
Copy link
Contributor Author

Looks like analyses do indeed support the group config!

Example analyses/_properties.yml:

groups:
  - name: galois
    owner:
      name: Évariste Galois
      email: [email protected]

analyses:
  - name: my_analysis
    group: galois

Here's a screenshot from manifest.json:

image

And here is the result of listing analyses that match this group:

$ dbt list --select "group:galois" --resource-types analysis -q

my_project.analysis.my_analysis

It works back to v1.5:

$ dbt list --select "group:galois" --resource-types analysis   

22:18:29  Running with dbt=1.5.9
22:18:30  Registered adapter: duckdb=1.5.2
22:18:30  Found 1 model, 0 tests, 0 snapshots, 1 analysis, 323 macros, 0 operations, 0 seed files, 3 sources, 0 exposures, 0 metrics, 2 groups

my_project.analysis.my_analysis

@dbeatty10 dbeatty10 mentioned this issue Jul 25, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dbeatty10 dbeatty10

@mirnawong1 mirnawong1

Labels
content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear priority: high Technical inaccuracy, missing/incorrect information, or broken links. Negatively affects workflows size: x-small This change will take under 3 hours to fix.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Analyses support the group config since v1.5 dbt-labs/docs.getdbt.com
3 participants
@dbeatty10 @graciegoheen @mirnawong1