Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more warehouses to Database Permissions section within references #3901

Closed
1 task done
agnessnowplow opened this issue Aug 10, 2023 · 1 comment
Closed
1 task done

Add more warehouses to Database Permissions section within references #3901

agnessnowplow opened this issue Aug 10, 2023 · 1 comment
Labels
content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear priority: high Technical inaccuracy, missing/incorrect information, or broken links. Negatively affects workflows size: medium This change will take up to a week to address

Comments

@agnessnowplow
Copy link
Contributor

Contributions

  • I have read the contribution docs, and understand what's expected of me.

Link to the page on docs.getdbt.com requiring updates

https://docs.getdbt.com/reference/snowflake-permissions
https://docs.getdbt.com/faqs/warehouse/database-privileges

What part(s) of the page would you like to see updated?

It would be great to list more warehouses by adding more pages under Database permissions, currently only Snowflake is listed. It would enable dbt users to quickly get access to the list of most useful / necessary grants needed.

There is also a FAQ on database privileges where once this is done we can just link those pages so the user can easily navigate there depending the warehouse they are using.

I am happy to contribute to this, if needed.

Additional information

No response
@agnessnowplow agnessnowplow added content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear labels Aug 10, 2023
@agnessnowplow agnessnowplow mentioned this issue Aug 17, 2023
Merged
6 tasks
@runleonarun
Copy link
Collaborator

Hello @agnessnowplow We'd love it if you can contribute to this work!

Here's a similar issue about the snowflake permissions page that's requesting we provide more context in that page.. #3824

@runleonarun runleonarun added priority: high Technical inaccuracy, missing/incorrect information, or broken links. Negatively affects workflows size: medium This change will take up to a week to address labels Aug 22, 2023
mirnawong1 added a commit that referenced this issue Nov 1, 2023
@mirnawong1
Add more warehouses to database permissions (#3943)
5422e9a 
## What are you changing in this pull request and why?
The proposed changes are regarding this issue raised last week:
#3901

It would be nice to have more warehouses within References / warehouse
permissions with sample grants, this PR aims to follow the already
existing
[Snowflake](https://docs.getdbt.com/reference/snowflake-permissions)
example and add Databricks, Redshift, and Postgres as well (skipping
BigQuery due to their unique IAM access control management)

#Resolves #3824

## Checklist
<!--
Uncomment if you're publishing docs for a prerelease version of dbt
(delete if not applicable):
- [ ] Add versioning components, as described in [Versioning
Docs](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#versioning-entire-pages)
- [ ] Add a note to the prerelease version [Migration
Guide](https://github.com/dbt-labs/docs.getdbt.com/tree/current/website/docs/guides/migration/versions)
-->
- [x] Review the [Content style
guide](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/content-style-guide.md)
and [About
versioning](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#adding-a-new-version)
so my content adheres to these guidelines.
- [x] Add a checklist item for anything that needs to happen before this
PR is merged, such as "needs technical review" or "change base branch."

Adding new pages (delete if not applicable):
- [x] Add page to `website/sidebars.js`
- [x] Provide a unique filename for the new page

- [x] Needs to have a technical review, at least to verify the proposed
changes are correct and possibly expand with other examples.
- [x] Tested it locally (npm run)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear priority: high Technical inaccuracy, missing/incorrect information, or broken links. Negatively affects workflows size: medium This change will take up to a week to address
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@runleonarun @mirnawong1 @agnessnowplow