Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-2642] Redirect links to supported-data-platforms#adapter-installation #7789

Closed
1 task done
dbeatty10 opened this issue Jun 3, 2023 · 3 comments
Closed
1 task done
Assignees
Labels
bug Something isn't working user docs [docs.getdbt.com] Needs better documentation

Comments

@dbeatty10
Copy link
Contributor

Contributions

  • I have read the contribution docs, and understand what's expected of me.

Link to the page on docs.getdbt.com requiring updates

❔ I don't yet know which page(s) would be most appropriate! 🀷

As a first pass, my intent here is document a recent mismatch so that we can figure out the best way to reconnect the dots. See "additional information" below for background context.

Primary impacted pages:

Secondary related pages:

What part(s) of the page would you like to see updated?

@mirnawong1 Do you know if https://docs.getdbt.com/docs/supported-data-platforms#adapter-installation can be redirected to https://docs.getdbt.com/docs/connect-adapters#install-using-the-cli ?

Additionally and/or alternatively, the URL can be updated within dbt-core (see "additional information" below for context).

Additional information

dbt-core logs the following error message when there is no adapter installed:

        msg = "No adapters available. Learn how to install an adapter by going to https://docs.getdbt.com/docs/supported-data-platforms#adapter-installation"

After the change in dbt-labs/docs.getdbt.com#3341, navigating to https://docs.getdbt.com/docs/supported-data-platforms#adapter-installation no longer goes to the intended location.

The replacement location in dbt-labs/docs.getdbt.com#3341 appears to be https://docs.getdbt.com/docs/connect-adapters#install-using-the-cli

mirnawong1 referenced this issue Jun 5, 2023
in response to [docs.getedbt.com pr 3465](https://github.com/dbt-labs/docs.getdbt.com/issues/3465), updating this error message to point to the correct URL, which was recently changed. 

old URL: https://docs.getdbt.com/docs/supported-data-platforms#adapter-installation
new URL: https://docs.getdbt.com/docs/connect-adapters#install-using-the-cli

thank you @dbeatty10 for your πŸ¦… πŸ‘€ !
@mirnawong1 mirnawong1 mentioned this issue Jun 5, 2023
6 tasks
@mirnawong1
Copy link
Contributor

hey @dbeatty10 oh dear, thank you for your detailed documentation on the problem statement here! ok so i believe we cannot redirect from a hash link to a different hash link (see slack thread for convo.

however, i have updated the URL within dbt core (and will also look to see if there's other similar error messages) - can you please look at my first core PR? also I'm trying to do the changie bit πŸ™

@dbeatty10 dbeatty10 transferred this issue from dbt-labs/docs.getdbt.com Jun 5, 2023
@github-actions github-actions bot changed the title Redirect links to supported-data-platforms#adapter-installation [CT-2642] Redirect links to supported-data-platforms#adapter-installation Jun 5, 2023
@dbeatty10
Copy link
Contributor Author

@mirnawong1 I transferred this issue to dbt-core since that's where we are implementing the fix. Conveniently, it will allow you to reference this issue number when you create the changelog entry via changie 😎

We can transfer it back to docs.getdbt.com if you deem that's better.

@dbeatty10 dbeatty10 added the bug Something isn't working label Jun 5, 2023
@jtcohen6 jtcohen6 added the user docs [docs.getdbt.com] Needs better documentation label Jun 12, 2023
@mirnawong1
Copy link
Contributor

resolved by pr #7779 (forgot to link)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working user docs [docs.getdbt.com] Needs better documentation
Projects
None yet
Development

No branches or pull requests

3 participants