-
Notifications
You must be signed in to change notification settings - Fork 497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ci command #771
Update ci command #771
Conversation
An update on my dbt_utils CI woes: Fixed:
Not so much fixed as swept under the carpet:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, this looks good and glad CI can get to green!
Due to the change to dbt build
, you'll need to update two other places to keep everything aligned (since $(models)
and $(seeds)
parameters to run_test.sh
are no longer functional):
Line 5 in 9507d6b
@./run_test.sh $(target) $(models) $(seeds) |
dbt-utils/integration_tests/README.md
Lines 75 to 90 in 9507d6b
```shell | |
make test target=postgres | |
``` | |
or, to run tests for a single model: | |
```shell | |
make test target=[postgres|redshift|...] [models=...] [seeds=...] | |
``` | |
or more specific: | |
```shell | |
make test target=postgres models=sql.test_star seeds=sql.data_star | |
``` | |
Specying `models=` and `seeds=` is optional, however _if_ you specify `seeds`, you have to specify `models` too. |
Also, would be good to create an issue to come back and enable that flakey test (if you haven't already).
run_test.sh
Outdated
fi | ||
dbt run -x --target $1 $_models || exit 1 | ||
dbt test -x --target $1 $_models || exit 1 | ||
dbt build --target $1 --full-refresh || exit 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes made and issue opened: #788 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more code suggestion to accept as-is or format as desired.
Approving so you can immediately merge after that is applied.
@@ -1,4 +1,7 @@ | |||
|
|||
{# This keeps succeeding locally and failing in CI. Disabling it to get everything else out, but it should still be tested. #} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add a link to the issue in GitHub so that anyone reading will know that there's an issue to address this item of tech debt.
{# This keeps succeeding locally and failing in CI. Disabling it to get everything else out, but it should still be tested. #} | |
{# This keeps succeeding locally and failing in CI. Disabling it to get everything else out, but it should still be tested. | |
https://github.com/dbt-labs/dbt-utils/issues/788 #} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops! Didn't realize there is a merge queue to auto-merge immediately after approval, so this suggestion didn't get applied.
Opened this PR to address this piece:
#789
* Update ci command * Update run_test.sh * Update run_test.sh * Change to large resource_class * Force dependency * force dependency * logging debugging * skip on postgres * .type * Remove redundant seed configs * Switch back to mod for redshift instead of % * Disable get_column_values default for a bit * Disable get_column_values_use_default * remove logging * Apply code review changes
trying to fix up the weird CI errors we're seeing