Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Databricks handler for get_table_types_sql.sql #769

Merged
merged 3 commits into from
Mar 15, 2023

Conversation

Harmuth94
Copy link
Contributor

@Harmuth94 Harmuth94 commented Feb 15, 2023

resolves #768

This is a:

  • documentation update
  • bug fix with no breaking changes
  • new functionality
  • a breaking change

All pull requests from community contributors should target the main branch (default).

Description & motivation

get_relations_by_pattern throws an error when using the databricks adapter on schemas in a Unity catalog. The error comes from the table having the table_type MANAGED in the information_schema.tables table.
Adding a handler for databricks allows the macro to as expected with data in a Unity catalog.

Checklist

  • This code is associated with an Issue which has been triaged and accepted for development.
  • I have verified that these changes work locally on the following warehouses (Note: it's okay if you do not have access to all warehouses, this helps us understand what has been covered)
    • BigQuery
    • Postgres
    • Redshift
    • Snowflake
    • Databricks
  • I followed guidelines to ensure that my changes will work on "non-core" adapters by:
    • dispatching any new macro(s) so non-core adapters can also use them (e.g. the star() source)
    • using the limit_zero() macro in place of the literal string: limit 0
    • using dbt.type_* macros instead of explicit datatypes (e.g. dbt.type_timestamp() instead of TIMESTAMP
  • I have updated the README.md (if applicable)
  • I have added tests & descriptions to my models (and macros if applicable)
  • I have added an entry to CHANGELOG.md

@Harmuth94 Harmuth94 changed the title Add Databricks handler for Add Databricks handler for get_table_types_sql.sql Feb 15, 2023
@Harmuth94
Copy link
Contributor Author

Tests for Redshift and bigquery are failing but the proposed change does not affect them in any way.

Copy link
Contributor

@joellabes joellabes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! Thanks @Harmuth94 🤩 sorry for the delay in getting back to you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get_relations_by_pattern for Databricks connection with Unity catalog
2 participants