Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add where clause example #623

Merged
merged 2 commits into from
Sep 14, 2022
Merged

Add where clause example #623

merged 2 commits into from
Sep 14, 2022

Conversation

arsenkhy
Copy link
Contributor

@arsenkhy arsenkhy commented Jul 16, 2022 •
edited
Loading

  • Provided example of optional where clause in get_columns_values

This is a:

  • documentation update
  • I have updated the README.md (if applicable)

Fixes #618

@arsenkhy
Add where clause example
1fb3ebd 
- Provided example of optional where clause in get_columns_values
joellabes
joellabes approved these changes Jul 28, 2022
View reviewed changes
Copy link
Contributor

@joellabes joellabes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @arsenkhy this is a good idea to add to the docs! Thanks for opening the PR.

The code as you had written it wouldn't compile - I have tweaked it a bit on your behalf 👍

README.md Outdated Show resolved Hide resolved
@joellabes joellabes merged commit 064c2ab into dbt-labs:main Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joellabes joellabes joellabes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Example using where parameter of get_column_values
2 participants
@arsenkhy @joellabes