-
Notifications
You must be signed in to change notification settings - Fork 497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sequential values test #318
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
781fc74
to
2f709a9
Compare
bbba960
to
60a3b3c
Compare
2f709a9
to
6f28888
Compare
huh, this works locally, and worked before I cleaned up this branch 🤔 |
Database Error in model test_dateadd (models/cross_db_utils/test_dateadd.sql)
TIMESTAMP_ADD does not support the MONTH date part at [36:9] OK leaving this for now, it's chewing up too much time |
26a10d3
to
3c502f9
Compare
Closing in favor of #327 |
Taking jtcohen's approval on #318 as approval here ;)
This is a:
master
dev/
branchdev/
branchDescription & motivation
This macro builds on work done in #264, to add a general test that a column has sequential values (i.e. an arithmetic series)
It's a little different to the exact functionality of that test, but I think this one is more generally useful
🚨 Note: when getting the tests passing, I noticed that the
date_add
macro has some strange behavior on BigQuery — we usedatetime_add
, and cast to a datetime rather than a timestamp (thus losing any timezone info). I thought it would be preferential to usetimestamp_add
here instead, which meant I ended up touching some other files. @jtcohen6 — I'd really like your eyes on that part of the codeChecklist