-
Notifications
You must be signed in to change notification settings - Fork 497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to CircleCI workflow #316
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really great! Curious why we decided to have the three clouds depend on postgres, I'm guessing to catch errors early?
While we're here, I wouldn't hate adding the |
Yeah, that was my initial thought, but we don't need to do it that way—the tests are so fast, it's not like it saves us very much.
Good call! |
This is unexpected:
I wonder if this is the result of a weird interaction with |
(I kind of liked the "postgres first" DAG) |
oh of course edit: I actually think this might because I kicked off tests on a different branch, messing with the redshift env that had already been built, which is exactly what #317 tries to solve! |
b1cb13e
to
d91c386
Compare
Hm I don't think this is a matter of the concurrent run (though that is a potential problem!). I ran What's weird is that I was able to |
…0-19 Fix: insert by period for 0.19
broken commit: update internals of insert by period
resolves #315
This is a:
master
dev/
branchdev/
branch