-
Notifications
You must be signed in to change notification settings - Fork 497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New test: accepted_range #276
Conversation
This looks I will test it out later this week :) |
@clrcrl README mistakes are fixed, thanks for catching them! I can see the CI tests failed but can't log into CircleCI to see why - are they mine? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're missing a columns:
entry, which is causing the tests to fail
Co-authored-by: Claire Carroll <[email protected]>
Kickin' off those tests now! |
Thank you for the great new feeature. I look forward to using it. |
We'll be doing utils 0.7.0 in line with dbt-core 0.19.0, which I think is coming up in mid-December. In the meantime, you can either:
(b) copying this macro into your own project (in the FWIW, I'd go with (b), just in case we introduce a breaking change into this branch |
Thank you for sharing the knowledge. I will try it out. |
@clrcrl Please let me know when 0.7.0 is out, if you know. If there is any blocker and anything I can contribute to, please let me know as well. Thanks. |
Add integration tests Add accepted_range documentation Fixing invalid yaml in readme Add missing columns: entry Co-authored-by: Claire Carroll <[email protected]> Update changelog
Add integration tests Add accepted_range documentation Fixing invalid yaml in readme Add missing columns: entry Co-authored-by: Claire Carroll <[email protected]> Update changelog
This is a:
main
)Description & motivation
This adds an accepted_range test, allowing users to ensure things like that a percentage is between 0 and 100, or that all accounts were created in the past. Technically, if you made a test with a
min_value
of 'A' andmax_value
of '[', I guess you could also check that all names started with a capital letter, but you shouldn't.I'm open to discussion on the min_value and max_value arguments. I'm tempted to call them greater_than and less_than because I feel like that might make more sense when you're not comparing a scalar number, but I think it's friendlier for the most common case right now.
Checklist