Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow hostname to be provided with or without a trailing slash #784

Merged
merged 3 commits into from
Jun 26, 2023
Merged

Allow hostname to be provided with or without a trailing slash #784

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6d01241
Ignore trailing / in host name
tim-steinkuhler May 21, 2023
7aa2460
Update changelog
tim-steinkuhler May 21, 2023
5a61bb8
Merge branch 'main' into tst/ct-410-handle-host-name-with-backslash
colin-rogers-dbt Jun 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changes/unreleased/Fixes-20230623-112100.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
kind: Fixes
body: Allow hostname to be provided with or without trailing slash
time: 2023-06-23T11:21:00.901430172Z
custom:
Author: tim-steinkuhler
Issue: "302"
3 changes: 3 additions & 0 deletions dbt/adapters/spark/connections.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,9 @@ def __post_init__(self) -> None:
f"ImportError({e.msg})"
) from e

if self.method != SparkConnectionMethod.SESSION:
self.host = self.host.rstrip("/")

@property
def type(self) -> str:
return "spark"
Expand Down