Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BACKPORT] #403 to 1.1.latest #521

Merged
merged 6 commits into from
Nov 17, 2022
Merged

[BACKPORT] #403 to 1.1.latest #521

merged 6 commits into from
Nov 17, 2022

Conversation

McKnight-42
Copy link
Contributor

@McKnight-42 McKnight-42 commented Nov 17, 2022 •
edited
Loading

resolves #403

Description

backporting changes to pip install for gha to 1.1.latest
also incorporates changes from #405 and #359 (skip of test that is failing in run)

todo:

  • do we need to also backport a version of this to 1.0?

Checklist

@McKnight-42 McKnight-42 added cla:yes Skip Changelog Skips GHA to check for changelog file labels Nov 17, 2022
@McKnight-42 McKnight-42 self-assigned this Nov 17, 2022
@McKnight-42 McKnight-42 changed the base branch from main to 1.1.latest November 17, 2022 16:41
@McKnight-42 McKnight-42 reopened this Nov 17, 2022
@McKnight-42 McKnight-42 merged commit a400fe0 into 1.1.latest Nov 17, 2022
@McKnight-42 McKnight-42 deleted the mcknight/backport-403-1.1 branch November 17, 2022 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leahwicz leahwicz leahwicz approved these changes

@jtcohen6 jtcohen6 Awaiting requested review from jtcohen6

Assignees

@McKnight-42 McKnight-42

Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@McKnight-42 @leahwicz