Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-868] Pin pyodbc in dbt-spark #398

Merged
merged 4 commits into from
Jul 21, 2022
Merged

[CT-868] Pin pyodbc in dbt-spark #398

merged 4 commits into from
Jul 21, 2022

Conversation

barberscott
Copy link
Contributor

Pin pyodbc to a known-working version until pyodbc>=4.0.35 releases.

resolves #397

Description

Pin the pyodbc version to prevent a bad installation of libodbc.so and libltdl.s on linux distros.

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt-spark next" section.

Pin pyodbc to a known-working version until pyodbc>=4.0.35 releases.
@cla-bot
Copy link

cla-bot bot commented Jul 20, 2022

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, don't hesitate to ping @drewbanin.

CLA has not been signed by users: @barberscott

@cla-bot cla-bot bot added the cla:yes label Jul 20, 2022
@barberscott barberscott marked this pull request as ready for review July 20, 2022 04:25
@jtcohen6 jtcohen6 added the ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering label Jul 20, 2022
Copy link
Contributor

@nathaniel-may nathaniel-may left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If CI passes, this dep pin looks fine to me.

@jtcohen6 jtcohen6 merged commit 80c1775 into main Jul 21, 2022
@jtcohen6 jtcohen6 deleted the pin-pyodbc-4032 branch July 21, 2022 15:48
@jtcohen6
Copy link
Contributor

@nathaniel-may Let's also backport to 1.2.latest so this gets included in the final release next week

@nathaniel-may nathaniel-may removed the ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering label Jul 21, 2022
@nathaniel-may nathaniel-may self-assigned this Jul 21, 2022
@nathaniel-may nathaniel-may mentioned this pull request Jul 21, 2022
4 tasks
francescomucio pushed a commit to francescomucio/dbt-spark that referenced this pull request Jul 26, 2022
* [CT-868] Pin pyodbc in dbt-spark 

Pin pyodbc to a known-working version until pyodbc>=4.0.35 releases.

* Update CHANGELOG.md

* Update CHANGELOG.md

* Update CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-868] Pin pyodbc to 4.0.32 until >4.0.34 is released
3 participants