fix issue parsing structs #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtcohen6
added a commit
that referenced
this pull request
Aug 23, 2021
* fix issue parsing structs * include contributor in changelog * better error explanation Co-authored-by: Jeremy Cohen <[email protected]>
jtcohen6
added a commit
that referenced
this pull request
Aug 23, 2021
* fixed get_columns_in_relation for open source delta table (#207) * fixed get_columns_in_relation for open source delta table * fixed E501 linting error and added change log * fix issue parsing structs (#204) * fix issue parsing structs * include contributor in changelog * better error explanation Co-authored-by: Jeremy Cohen <[email protected]> Co-authored-by: Hariharan Banukumar <[email protected]> Co-authored-by: Sergio <[email protected]>
leahwicz
added a commit
that referenced
this pull request
Sep 17, 2021
* Show more detailed feedback when pyodbc import fails (#192) * Use exception chaining to get more detailed feedback when pyodbc is not installed * Remove pyodbc referenced before assignment * Set back try except * Add flake ignore * Add error message to RunTimeException Error chaining does not show the message in `dbt debug`. Therefore we explicitly add the message to the dbt.exceptions.RunTimeException * Update change log Add to change log that we print the import error when pyodbc can not be imported * Fix parenthesis in change log * Update changelog [skip ci] * Update changelog [skip ci] * Update changelog [skip ci] * Add support for ODBC Server Side Parameters (#201) * Add support for ODBC Server Side Parameters * Update CHANGELOG * Feature/able to retry all connections (#194) * Code changes * README changes * Improve error message default * Changelog * Changelog corrections * Restore accidental deletion * Update dbt/adapters/spark/connections.py Co-authored-by: Jeremy Cohen <[email protected]> * Add myself to Contributors Co-authored-by: Jeremy Cohen <[email protected]> * fixed get_columns_in_relation for open source delta table (#207) * fixed get_columns_in_relation for open source delta table * fixed E501 linting error and added change log * fix issue parsing structs (#204) * fix issue parsing structs * include contributor in changelog * better error explanation Co-authored-by: Jeremy Cohen <[email protected]> * Add adapter unique_field (#211) * Add adapter unique_field * Fix flake8. Add changelog entry * [Snyk] Fix for 2 vulnerabilities (#214) * fix: requirements.txt to reduce vulnerabilities The following vulnerabilities are fixed by pinning transitive dependencies: - https://snyk.io/vuln/SNYK-PYTHON-SQLPARSE-1584201 - https://snyk.io/vuln/SNYK-PYTHON-THRIFT-474615 * Removing Thrift conflict with versions over 12 Co-authored-by: leahwicz <[email protected]> * 0.21.0b1 Release * Bumping version to 0.21.0b1 * Bumping to 0.21.0b2 * Bumping version to 0.21.0b2 Co-authored-by: Cor <[email protected]> Co-authored-by: Jeremy Cohen <[email protected]> Co-authored-by: Jethro Nederhof <[email protected]> Co-authored-by: gregingenii <[email protected]> Co-authored-by: Jeremy Cohen <[email protected]> Co-authored-by: Hariharan Banukumar <[email protected]> Co-authored-by: Sergio <[email protected]> Co-authored-by: Snyk bot <[email protected]> Co-authored-by: Ian Knox <[email protected]> Co-authored-by: Leah Antkiewicz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #202
Description
The issue was when parsing the schema, the current regex deal with inner struct fields as root fields, hence causing an error later because the column was not found (check issue #202 for a more detailed description)
Current one:
Proposed one:
Checklist
CHANGELOG.mdand added information about my change to the "dbt next" section. (Not sure if I did this right, let me know if it's something else to improve)