Make the https:// optional

[Fokko]

resolves #153

Description

This allows you to both do:

default:
  target: dev
  outputs:
    dev:
...
      host: adb-8170469668123456.8.azuredatabricks.net

and:

default:
  target: dev
  outputs:
    dev:
...
      host: https://adb-8170469668123456.8.azuredatabricks.net

Checklist

• I have signed the CLA
• I have run this code in development and it appears to resolve the stated issue
• This PR includes tests, or tests are not required/relevant for this PR
• I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

[jtcohen6]

Thanks for this one @Fokko! I'm all about it

[jtcohen6]

It looks like flake8 is giving you a hard time for this line being too long:

dbt/adapters/spark/connections.py:324:80: E501 line too long (106 > 79 characters)

[Fokko]

Dang! Thanks for pointing it out. Just pushed a fix

[jtcohen6]

LGTM! Thanks for this @Fokko!

[joebeeson]

Just ran into this issue after tracing down why I couldn't set HTTP vs HTTPS on a local testing installation. Is it appropriate to assume the connection is HTTPS? Particularly with no way to configure it otherwise.

[jtcohen6]

@joebeeson That's a fair thought. I guess I'd hope that folks are connecting to their Spark clusters via HTTPS, but you never know.

Perhaps we could switch the logic added by this PR:

https://github.com/fishtown-analytics/dbt-spark/blob/dff1b613ddf87e4e72e8a47475bcfd1d55796a5c/dbt/adapters/spark/connections.py#L323-L326

To instead be:

 if not host.startswith('http'):
       host = 'https://' + creds.host 

That way, https:// is presumed by default, but if you want to explicitly specify http://your.host.name in profiles.yml, you could.

Is that a switch you'd be interested in contributing?