fix(format): Fixed SQL view formatting issue not following SQLFluff recommandations #1154
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
If the
sql
string variable in therelations/view/create.sql
macro has multiple lines, the SQL view generated by dbt has one first line indented by 4 spaces, but the rest of the SQL code has no indentation.This does not respect SQLFluff best practices for indentation : https://docs.sqlfluff.com/en/stable/layout.html#indentation
Solution
By adding the Jinja2
indent
function :https://jinja.palletsprojects.com/en/3.1.x/templates/#jinja-filters.indent
We are able to indent all content from the
sql
variable (except the first line which is already indented) !Checklist