Backport typing extensions version update to 0.4 #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
tlento
commented
Nov 4, 2023
tlento
commented
- Update typing-extensions to require versions >=4.4 (Add typing-extensions>=4.4 requirement #194)
- Prevent typing-extensions from auto-updating to 5.x (Prevent typing-extensions from auto-updating to 5.x #200)
Support for the `@override` keyword was added with typing-extensions 4.4, but the previous version spec made it possible for end users to encounter errors when attempting to use dbt or MetricFlow.
The typing-extensions project announced adherence to semver with 4.0.0, which means, at least in theory, 5.0 might include breaking changes. Rather than risk user packages auto-updating to backwards-incompatible versions, we pin this back to ~=4.0, which is equivalent to >=4.0, <5.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.