Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CT-2819] default__alter_relation_add_remove_columns macro does not use quoting with case sensitive Snowflake relation #854

Closed
wants to merge 7 commits into from
Closed

[CT-2819] default__alter_relation_add_remove_columns macro does not use quoting with case sensitive Snowflake relation #854

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
33fa8f7
update redshift version of macro alter_relation_add_remove_column and…
McKnight-42 Jul 12, 2024
98ec420
pull in new basclass and run test
McKnight-42 Jul 16, 2024
dd0696f
update dev-requirements
McKnight-42 Jul 17, 2024
4876307
Merge branch 'main' of https://github.com/dbt-labs/dbt-redshift into …
McKnight-42 Jul 17, 2024
8000392
Merge branch 'main' of https://github.com/dbt-labs/dbt-redshift into …
McKnight-42 Jul 18, 2024
77bdf03
Merge branch 'main' into mcknight/2819
McKnight-42 Jul 24, 2024
3064ec0
Merge branch 'main' into mcknight/2819
colin-rogers-dbt Jul 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dbt/include/redshift/macros/adapters.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,7 @@

{% for column in add_columns %}
{% set sql -%}
alter {{ relation.type }} {{ relation }} add column {{ column.name }} {{ column.data_type }}
alter {{ relation.type }} {{ relation }} add column {{ adapter.quote(column.name) }} {{ column.data_type }}
{% endset %}
{% do run_query(sql) %}
{% endfor %}
Expand All @@ -304,7 +304,7 @@

{% for column in remove_columns %}
{% set sql -%}
alter {{ relation.type }} {{ relation }} drop column {{ column.name }}
alter {{ relation.type }} {{ relation }} drop column {{ adapter.quote(column.name) }}
{% endset %}
{% do run_query(sql) %}
{% endfor %}
Expand Down
4 changes: 2 additions & 2 deletions dev-requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# install latest changes in dbt-core + dbt-postgres
git+https://github.com/dbt-labs/dbt-adapters.git
git+https://github.com/dbt-labs/dbt-adapters.git#subdirectory=dbt-tests-adapter
git+https://github.com/dbt-labs/dbt-adapters.git@mcknight/ct-2819
git+https://github.com/dbt-labs/dbt-adapters.git@mcknight/ct-2819#subdirectory=dbt-tests-adapter
git+https://github.com/dbt-labs/dbt-common.git
git+https://github.com/dbt-labs/dbt-core.git#subdirectory=core
git+https://github.com/dbt-labs/dbt-postgres.git
Expand Down
5 changes: 5 additions & 0 deletions tests/functional/adapter/incremental/test_incremental_on_schema_change.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,12 @@
from dbt.tests.adapter.incremental.test_incremental_on_schema_change import (
BaseIncrementalOnSchemaChange,
BaseIncrementalCaseSenstivityOnSchemaChange,
)


class TestIncrementalOnSchemaChange(BaseIncrementalOnSchemaChange):
pass


class TestIncrementalCaseSenstivityOnSchemaChange(BaseIncrementalCaseSenstivityOnSchemaChange):
pass
Loading