Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change node shape based on access type. #389

Merged
merged 1 commit into from
Mar 7, 2023
Merged

change node shape based on access type. #389

merged 1 commit into from
Mar 7, 2023

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Mar 7, 2023

resolves #378

Description

Here's what I came up with with the help of @dbeatty10

access: protected - nothing custom - stays the rounded corner rectangle. This allows the DAG to visually remain exactly the same until groups/access are added to a project
access: public - ellipse shape - This really distinguishes the public nodes that will be accessible outside the project
access: private - sharp cornered rectangle

node access
raw_people_list no access defined explicitly
second-model-private access: private
second-model-public access: public
top-model access: protected

Screen Shot 2023-03-07 at 10 49 52 AM

Checklist

@cla-bot cla-bot bot added the cla:yes label Mar 7, 2023
@emmyoop emmyoop merged commit b503c68 into main Mar 7, 2023
@emmyoop emmyoop deleted the er/ct-2201-access branch March 7, 2023 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-2201] DAG visualization: visually distinguish models based on 'access'
2 participants