Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-1980] Welcome message not shown in dbt docs #366

Closed
halvorlu opened this issue Jan 31, 2023 · 2 comments · Fixed by #367
Closed

[CT-1980] Welcome message not shown in dbt docs #366

halvorlu opened this issue Jan 31, 2023 · 2 comments · Fixed by #367
Labels
bug Something isn't working

Comments

@halvorlu
Copy link
Contributor

Describe the bug

The overview page of dbt docs shows "(loading)" instead of the welcome message. There is an error in the console: "TypeError: Cannot read properties of undefined (reading 'block_contents')"

Steps To Reproduce

Run dbt init, dbt docs generate and dbt docs serve with dbt version 1.4.

Expected behavior

Expected to see the default welcome message on the overview page of dbt docs.

Screenshots and log output

image

The output of dbt --version:

Core:
  - installed: 1.4.1
  - latest:    1.4.1 - Up to date!

Plugins:
  - bigquery: 1.4.0 - Up to date!
@halvorlu halvorlu added bug Something isn't working triage labels Jan 31, 2023
@github-actions github-actions bot changed the title Welcome message not shown in dbt docs [CT-1980] Welcome message not shown in dbt docs Jan 31, 2023
halvorlu added a commit to halvorlu/dbt-docs that referenced this issue Jan 31, 2023
@halvorlu
Copy link
Contributor Author

I believe this is due to a new path for dbt.__overview__ in manifest.json, which is now doc.dbt.__overview__ in dbt 1.4.

@jtcohen6
Copy link
Contributor

@halvorlu Thanks for opening, and diagnosing! This should be a quick fix. I opened a corresponding issue in dbt-core (dbt-labs/dbt-core#6801) just to track this as a v1.4 regression that we should include in v1.4.x patch release

@dbeatty10 dbeatty10 removed the triage label Feb 1, 2023
emmyoop pushed a commit that referenced this issue Feb 9, 2023
* Fix JSON path to overview docs

Fixes #366

* Changelog entry

---------

Co-authored-by: Doug Beatty <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants